-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ETag to Access-Control-Expose-Headers headers #668
Conversation
I also created a codesandbox example that demonstrates the issue, but it has a few caveats:
|
The extension to add |
@reimannf, I had those changes ready to go locally so I created a PR (#674) instead of adding to this one, however, I'm not sure if it's the right solution. The fact that nobody has brought up the issue in the last 2 years shows that few people might care about customizing that Seems to me like the only 2 headers that most people care about are If you really feel like you would prefer a new configuration knob then feel free to move over to #674 instead of this and I'll close this one. |
Understand your arguments, but as you described for this specific lib, one would need already 2 headers. |
I'll close this for now and we can migrate to #674 |
Thank you @reimannf for your feedback! |
I mentioned this in issue #667 but suffice to say that, while
ETag
is available as a header from many of the APIs in S3Proxy, the browser cannot access it since it's missing from theAccess-Control-Expose-Headers
list. To allow accessing this header from the browser, it needs to be added to the Access-Control-Expose-Headers header.